This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
[ci benches]: use all-features
#11496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our benches are hidden behind feature flags, this PR enables to type check on those. `--all` is deprecated
niklasad1
added
A2-insubstantial 👶
ordian
approved these changes
Feb 15, 2020
dvdplm
approved these changes
Feb 15, 2020
|
Bench check failure is legit. |
The `memory_profiling` feature doesn't work because `parity_util_mem` crate configures it globally.
niklasad1
commented
Feb 16, 2020
| # or | ||
| # `valgrind --tool=massif /path/to/parity <parity params>` | ||
| # and `massif-visualizer` for visualization | ||
| memory_profiling = [] |
There was a problem hiding this comment.
//cc @ordian
This doesn't seem to with parity-util-mem because it configures global jemalloc so I removed it, thoughts?
Maybe, we do something inside parity-util-mem instead (but quite annoying to use here here with additive feature flags)?
There was a problem hiding this comment.
ah, right, it's outdated now, let's remove it and for memory profiling we would need to modify https://github.com/paritytech/parity-ethereum/blob/ff78f4318ab2c51063622ef32cd15f9ce62d95d3/Cargo.toml#L62
ordian
added a commit
that referenced
this pull request
Mar 6, 2020
* master: (27 commits) Faster kill_garbage (#11514) [EngineSigner]: don't sign message with only zeroes (#11524) fix compilation warnings (#11522) [ethcore cleanup]: various unrelated fixes from `#11493` (#11507) Add benchmark for transaction execution (#11509) Add Smart Contract License v1.0 Misc fixes (#11510) [dependencies]: unify `rustc-hex` (#11506) Activate on-chain randomness in POA Sokol (#11505) Grab bag of cleanup (#11504) Implement eth/64 (EIP-2364) and drop support for eth/62 (#11472) [dependencies]: remove `util/macros` (#11501) OpenEthereum bootnodes are added (#11499) [ci benches]: use `all-features` (#11496) [verification]: make test-build compile standalone (#11495) complete null-signatures removal (#11491) Include the seal when populating the header for a new block (#11475) fix compilation warnings (#11492) cargo update -p cmake (#11490) update to published rlp-derive (#11489) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our benches are hidden behind feature flags, this PR enables to type check on those.
--allis deprecated