Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Reduced gas cost for static calls made to precompiles EIP2046/1352 #11583

Merged
merged 7 commits into from
Apr 6, 2020

Conversation

adria0
Copy link

@adria0 adria0 commented Mar 25, 2020

This PR implements:

It passes the GeneralStateTest written in ethereum/tests@8bbbd48 (change Istanbul+2046 for Berlin)

@adria0 adria0 changed the title Implemented eip2046 Reduced gas cost for static calls made to precompiles EIP2046/1352 Mar 25, 2020
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
A few grumbles on code format.

ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
ethcore/evm/src/interpreter/gasometer.rs Outdated Show resolved Hide resolved
ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
ethcore/builtin/src/lib.rs Outdated Show resolved Hide resolved
adria0 and others added 5 commits March 25, 2020 16:02
Co-Authored-By: Wei Tang <accounts@that.world>
Co-Authored-By: Wei Tang <accounts@that.world>
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Wei Tang <accounts@that.world>
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. labels Apr 6, 2020
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sorpaas sorpaas merged commit c0920b3 into openethereum:master Apr 6, 2020
dvdplm added a commit that referenced this pull request Apr 14, 2020
* master: (25 commits)
  Update .gitmodules (#11628)
  ethcore/res: activate ecip-1088 phoenix on classic (#11598)
  Upgrade parity-common deps to latest (#11620)
  Fix Goerli syncing (#11604)
  deps: switch to upstream ctrlc (#11617)
  Deduplicating crate dependencies (part 3 of n) (#11614)
  Deduplicating crate dependencies (part 2 of n, `slab`) (#11613)
  Actually save ENR on creation and modification (#11602)
  Activate POSDAO on xDai chain and update bootnodes (#11610)
  Activate on-chain randomness in POA Core (#11609)
  Deduplicating crate dependencies (part 1 of n) (#11606)
  Update enodes for POA Sokol (#11611)
  Remove .git folder from dogerignore file so vergen library can get build date and commit hash in the binary generatio vergen library can get build date and commit hash in the binary generation (#11608)
  Reduced gas cost for static calls made to precompiles EIP2046/1352 (#11583)
  [easy] `ethcore-bloom-journal` was renamed to `accounts-bloom` (#11605)
  Use serde_json to export hardcoded sync (#11601)
  Node Discovery v4 ENR Extension (EIP-868) (#11540)
  Fix compile warnings (#11595)
  Update version to 3.0.0-alpha.1 (#11592)
  ethcore/res: bump canon fork hash for mordor and kotti testnets (#11584)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants