-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Upgrade parity-common deps to latest #11620
Conversation
|
…h/parity-ethereum into dp/chore/upgrade-parity-crypto * 'dp/chore/upgrade-parity-crypto' of github.com:paritytech/parity-ethereum: ethash: use overlapping bytes after all ethash: sneaky spaces ethash: upgrade keccak-hash
What's up with the change of |
Sorry, my fault, will revert. |
…h/parity-ethereum into dp/chore/upgrade-parity-crypto * 'dp/chore/upgrade-parity-crypto' of github.com:paritytech/parity-ethereum: revert submodule update
* master: Fix Goerli syncing (#11604)
@@ -197,21 +198,17 @@ fn hash_compute(light: &Light, full_size: usize, header_hash: &H256, nonce: u64) | |||
// improvements, since I can't imagine that 3-5% of our runtime is taken up by catting two | |||
// arrays together. | |||
let mut buf: MixBuf = MixBuf { | |||
half_mix: unsafe { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
keccak-hash = "0.4.0" | ||
kvdb = "0.4.0" | ||
kvdb-rocksdb = "0.6.0" | ||
keccak-hash = "0.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be 0.5.1
?
Fixed in Cargo.lock
so it is fine to ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
let end = hash_len + mem::size_of::<u64>(); | ||
buf[hash_len..end].copy_from_slice(&nonce.to_ne_bytes()); | ||
|
||
keccak_512::unchecked(buf.as_mut_ptr(), 64, buf.as_ptr(), 40); | ||
keccak_512::inplace_range(&mut buf, 0..end); | ||
buf[64..].copy_from_slice(mix_hash); | ||
|
||
let mut hash = [0u8; 32]; | ||
keccak_256::unchecked(hash.as_mut_ptr(), hash.len(), buf.as_ptr(), buf.len()); | ||
keccak_256::write(&buf, &mut hash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change introduced a substantial regression, nothing stands out in benches paritytech/parity-common#372 though
it shouldn't be a blocker for merging this PR though, I'll work on bringing the perf back
[[package]] | ||
name = "error-chain" | ||
version = "0.12.2" | ||
source = "registry+https://github.com/rust-lang/crates.io-index" | ||
checksum = "d371106cc88ffdfb1eabd7111e432da544f16f3e2d7bf1dfe8bf575f1df045cd" | ||
dependencies = [ | ||
"version_check", | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
@q9f EDIT: Sorry, spoke too early, the fix will be in another PR. |
* master: Upgrade parity-common deps to latest (#11620)
* master: (25 commits) Update .gitmodules (#11628) ethcore/res: activate ecip-1088 phoenix on classic (#11598) Upgrade parity-common deps to latest (#11620) Fix Goerli syncing (#11604) deps: switch to upstream ctrlc (#11617) Deduplicating crate dependencies (part 3 of n) (#11614) Deduplicating crate dependencies (part 2 of n, `slab`) (#11613) Actually save ENR on creation and modification (#11602) Activate POSDAO on xDai chain and update bootnodes (#11610) Activate on-chain randomness in POA Core (#11609) Deduplicating crate dependencies (part 1 of n) (#11606) Update enodes for POA Sokol (#11611) Remove .git folder from dogerignore file so vergen library can get build date and commit hash in the binary generatio vergen library can get build date and commit hash in the binary generation (#11608) Reduced gas cost for static calls made to precompiles EIP2046/1352 (#11583) [easy] `ethcore-bloom-journal` was renamed to `accounts-bloom` (#11605) Use serde_json to export hardcoded sync (#11601) Node Discovery v4 ENR Extension (EIP-868) (#11540) Fix compile warnings (#11595) Update version to 3.0.0-alpha.1 (#11592) ethcore/res: bump canon fork hash for mordor and kotti testnets (#11584) ...
ethabi*
crates