Deduplicating crate dependencies (part 3 of n) #11614
Conversation
…timer`, and co) (openethereum#11613) The change includes: ``` tiny-keccak tokio-timer textwrap winapi rand rand_xorshift scopeguard url ```
shergin
changed the title
| @@ -31,8 +31,11 @@ impl Hasher for KeccakHasher { | |||
| type StdHasher = PlainHasher; | |||
| const LENGTH: usize = 32; | |||
| fn hash(x: &[u8]) -> Self::Out { | |||
| use tiny_keccak::Hasher; | |||
There was a problem hiding this comment.
Why not use tiny_keccak::{Keccak, Hasher}; on line 23?
There was a problem hiding this comment.
I am n00b in Rust. I tried that originally and got compiler error saying something like "using trait implementations ... blah blah... must be in the scope", so I moved that to the scope and the error is gone. I will investigate why exactly (but it seems correct, ¯\_(ツ)_/¯).
tiny-keccak 1.5.0 is still there (used in ethbloom, keccak-hash, keccak-hasher, parity-secretstore) |
ordian
added
A6-mustntgrumble 💦
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
|
From my understanding, most of remaining duplicating dependencies are in 3rd-party deps (or maybe I am missing something), not sure what we should/can do with that. |
We still can deduplicate crates like syn and proc-macro2 by upgrading dependencies (ethabi, logos and validator -derive) and tiny-keccak (see the list above). |
|
Thank you folks! |
* master: (25 commits) Update .gitmodules (#11628) ethcore/res: activate ecip-1088 phoenix on classic (#11598) Upgrade parity-common deps to latest (#11620) Fix Goerli syncing (#11604) deps: switch to upstream ctrlc (#11617) Deduplicating crate dependencies (part 3 of n) (#11614) Deduplicating crate dependencies (part 2 of n, `slab`) (#11613) Actually save ENR on creation and modification (#11602) Activate POSDAO on xDai chain and update bootnodes (#11610) Activate on-chain randomness in POA Core (#11609) Deduplicating crate dependencies (part 1 of n) (#11606) Update enodes for POA Sokol (#11611) Remove .git folder from dogerignore file so vergen library can get build date and commit hash in the binary generatio vergen library can get build date and commit hash in the binary generation (#11608) Reduced gas cost for static calls made to precompiles EIP2046/1352 (#11583) [easy] `ethcore-bloom-journal` was renamed to `accounts-bloom` (#11605) Use serde_json to export hardcoded sync (#11601) Node Discovery v4 ENR Extension (EIP-868) (#11540) Fix compile warnings (#11595) Update version to 3.0.0-alpha.1 (#11592) ethcore/res: bump canon fork hash for mordor and kotti testnets (#11584) ...
The change includes:
#11468