This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Upgrade num to 0.2, use enum-primitive-derive #11636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Apr 20, 2020
dvdplm
suggested changes
Apr 20, 2020
|
@dvdplm sorry, added reasoning to PR description. |
So this PR is a performance win? Benches? Is EIP 2565 being considered for the Berlin HF? |
|
Performance data for EIP-2565: |
I have a hard time understanding the numbers there without further context. EIP 2565 makes sense to me, although I'm not 100% clear on what the gain is, but in general no opposition to optimizing gas prices to enable advanced crypto. This PR does not implement 2565 though right? So is this a prequel do further work? |
|
Updated to newly released enum-primitive-derive 0.2 |
vorot93
requested review from
niklasad1 and
dvdplm
and removed request for
dvdplm
niklasad1
reviewed
Jun 6, 2020
niklasad1
approved these changes
Jun 6, 2020
dvdplm
approved these changes
Jun 7, 2020
adria0
pushed a commit
that referenced
this pull request
Jun 9, 2020
dvdplm
added a commit
that referenced
this pull request
Jun 30, 2020
* master: Update parity-crypto dependency (#11791) ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764) Feature/publish draft release ci (#11786) Trigger custom docker build when adding ci-build-docker to the commit (#11782) Fix alpine docker image entry point (#11749) Use BigUint::modpow for ModExp precompile (#11772) Add YOLO-1 testnet (#11757) Upgrade num to 0.2, use enum-primitive-derive (#11636) Update Simple Subroutines to the latest spec (#11731) update secret-store reference (#11761) Implementation of EIP 2537 (#11707) Add missing forks to fork ID (#11747) Use nightly tag for master branch (#11732)
dvdplm
added a commit
that referenced
this pull request
Jun 30, 2020
…ereum/openethereum into dp/chore/upgrade-to-rocksdb-0.14 * 'dp/chore/upgrade-to-rocksdb-0.14' of github.com:openethereum/openethereum: Update parity-crypto dependency (#11791) ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764) Feature/publish draft release ci (#11786) Trigger custom docker build when adding ci-build-docker to the commit (#11782) Fix alpine docker image entry point (#11749) Use BigUint::modpow for ModExp precompile (#11772) Add YOLO-1 testnet (#11757) Upgrade num to 0.2, use enum-primitive-derive (#11636) Update Simple Subroutines to the latest spec (#11731) update secret-store reference (#11761) Implementation of EIP 2537 (#11707) Add missing forks to fork ID (#11747) Use nightly tag for master branch (#11732)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was highlighted during the AllCoreDevs call. num 0.1 is too slow and thus blocks the proposed repricing of ModExp precompile. enum-primitive is unmaintained, so switched to enum-primitive-derive which is based on num 0.2.