Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update simple subroutines (EIP 2315) to the latest spec #11731

Merged
merged 6 commits into from
Jun 5, 2020
Merged

Conversation

adria0
Copy link

@adria0 adria0 commented May 25, 2020

@holiman
Copy link
Contributor

holiman commented May 25, 2020

PTAL: ethereum/EIPs#2669

@holiman
Copy link
Contributor

holiman commented May 25, 2020

@adria0 , you should also be able to try out the state-tests: ethereum/tests#685 - parity-vm statetest <statetest> .

@vorot93 vorot93 mentioned this pull request Jun 3, 2020
@vorot93
Copy link

vorot93 commented Jun 5, 2020

ethereum/tests#693 has been merged

@vorot93 vorot93 requested a review from sorpaas June 5, 2020 12:57
@adria0 adria0 marked this pull request as ready for review June 5, 2020 13:37
@adria0 adria0 requested a review from vorot93 June 5, 2020 13:37
@adria0 adria0 added the A0-pleasereview 🤓 Pull request needs code review. label Jun 5, 2020
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against current spec LGTM.

ethcore/evm/src/interpreter/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Wei Tang <hi@that.world>
@vorot93 vorot93 changed the title Implement Simple Subroutines for the EVM (EIP 2315) Update simple subroutines (EIP 2315) to the latest spec Jun 5, 2020
@vorot93 vorot93 merged commit 58fde98 into master Jun 5, 2020
@vorot93 vorot93 deleted the adria0/eip2315 branch June 5, 2020 16:42
dvdplm added a commit that referenced this pull request Jun 30, 2020
* master:
  Update parity-crypto dependency (#11791)
  ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764)
  Feature/publish draft release ci (#11786)
  Trigger custom docker build when adding ci-build-docker to the commit (#11782)
  Fix alpine docker image entry point (#11749)
  Use BigUint::modpow for ModExp precompile (#11772)
  Add YOLO-1 testnet (#11757)
  Upgrade num to 0.2, use enum-primitive-derive (#11636)
  Update Simple Subroutines to the latest spec  (#11731)
  update secret-store reference (#11761)
  Implementation of EIP 2537 (#11707)
  Add missing forks to fork ID (#11747)
  Use nightly tag for master branch (#11732)
dvdplm added a commit that referenced this pull request Jun 30, 2020
…ereum/openethereum into dp/chore/upgrade-to-rocksdb-0.14

* 'dp/chore/upgrade-to-rocksdb-0.14' of github.com:openethereum/openethereum:
  Update parity-crypto dependency (#11791)
  ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764)
  Feature/publish draft release ci (#11786)
  Trigger custom docker build when adding ci-build-docker to the commit (#11782)
  Fix alpine docker image entry point (#11749)
  Use BigUint::modpow for ModExp precompile (#11772)
  Add YOLO-1 testnet (#11757)
  Upgrade num to 0.2, use enum-primitive-derive (#11636)
  Update Simple Subroutines to the latest spec  (#11731)
  update secret-store reference (#11761)
  Implementation of EIP 2537 (#11707)
  Add missing forks to fork ID (#11747)
  Use nightly tag for master branch (#11732)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants