This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Implementation of EIP 2537 #11707
Merged
Implementation of EIP 2537 #11707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc #11697 |
adria0
reviewed
May 22, 2020
adria0
reviewed
May 22, 2020
|
I'll review the https://github.com/matter-labs/eip1962/tree/1c79dba99c970c99066e249627c29b38dc949677 that is the used revision at this moment. |
|
Updated with a constant and specific revision |
adria0
reviewed
May 28, 2020
|
@sorpaas, if you have time, could you review it, please? |
sorpaas
approved these changes
Jun 2, 2020
Merged
vorot93
reviewed
Jun 3, 2020
|
I'll fix those tomorrow |
|
@vorot93 Ubuntu tests looks to go fine, but were cancelled due to MacOS tests. For MacOS tests I can not see logs and find an error, can you help me with it? |
|
All tests pass on my MacOS laptop by the way |
|
Restarted the tests |
vorot93
reviewed
Jun 4, 2020
ethcore/res/ethereum/foundation.json
Outdated
Comment on lines
4896
to
4898
| "0x7fffffffffffff": { | ||
| "price": { "bls12_const_operations": { "price": 600 }} | ||
| } |
There was a problem hiding this comment.
Suggested change
| "0x7fffffffffffff": { | |
| "price": { "bls12_const_operations": { "price": 600 }} | |
| } | |
| "bls12_const_operations": { "price": 600 } |
Either you set
activate_at:block_number, andpricing>bls12_const_operationsif there's a single pricing, orpricing>block_number>price>bls12_const_operationsif pricing is expected to change
but not both!
There was a problem hiding this comment.
This part I didn't change, only fixed names there and activation to be in a distant future as was suggested above.
There was a problem hiding this comment.
I may have missed this part, but still needs to be fixed.
vorot93
reviewed
Jun 4, 2020
Comment on lines
126
to
128
| "0": { | ||
| "price": { "bls12_const_operations": { "price": 600 }} | ||
| } |
There was a problem hiding this comment.
Suggested change
| "0": { | |
| "price": { "bls12_const_operations": { "price": 600 }} | |
| } | |
| "bls12_const_operations": { "price": 600 } |
also the same in this spec
vorot93
added
A8-looksgood 🦄
adria0
pushed a commit
that referenced
this pull request
Jun 9, 2020
dvdplm
added a commit
that referenced
this pull request
Jun 30, 2020
* master: Update parity-crypto dependency (#11791) ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764) Feature/publish draft release ci (#11786) Trigger custom docker build when adding ci-build-docker to the commit (#11782) Fix alpine docker image entry point (#11749) Use BigUint::modpow for ModExp precompile (#11772) Add YOLO-1 testnet (#11757) Upgrade num to 0.2, use enum-primitive-derive (#11636) Update Simple Subroutines to the latest spec (#11731) update secret-store reference (#11761) Implementation of EIP 2537 (#11707) Add missing forks to fork ID (#11747) Use nightly tag for master branch (#11732)
dvdplm
added a commit
that referenced
this pull request
Jun 30, 2020
…ereum/openethereum into dp/chore/upgrade-to-rocksdb-0.14 * 'dp/chore/upgrade-to-rocksdb-0.14' of github.com:openethereum/openethereum: Update parity-crypto dependency (#11791) ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764) Feature/publish draft release ci (#11786) Trigger custom docker build when adding ci-build-docker to the commit (#11782) Fix alpine docker image entry point (#11749) Use BigUint::modpow for ModExp precompile (#11772) Add YOLO-1 testnet (#11757) Upgrade num to 0.2, use enum-primitive-derive (#11636) Update Simple Subroutines to the latest spec (#11731) update secret-store reference (#11761) Implementation of EIP 2537 (#11707) Add missing forks to fork ID (#11747) Use nightly tag for master branch (#11732)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements EIP 2537 using the full reference implementation from here (specialized BLS12-381 engine).
Both json specs and native builtins are implemented (pricers and executors).
Closes #11677