Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ID types in user.proto file to be strings and user table ID types to be varchar(26) #59

Closed
codegold79 opened this issue Oct 19, 2019 · 0 comments · Fixed by #68
Closed

Change ID types in user.proto file to be strings and user table ID types to be varchar(26) #59

codegold79 opened this issue Oct 19, 2019 · 0 comments · Fixed by #68
Assignees
@codegold79
Labels
end: back

Comments

@codegold79
Copy link
Collaborator

codegold79 commented Oct 19, 2019 •
edited
Loading

The ID types in the user service are different types and require multiple type conversions. Ensure all the ID types are strings and user table ID types to be varchar(255).

  • msgs/proto/user.proto requires IDs to be uint32
  • back/internal/usersvc/internal/userdb/qryuser.go accepts IDs that are of type string

Once the types are string/varchar, then update the responses to return the UIDs instead of hard-coded integers.
This was referenced Oct 19, 2019
Merged
Closed
@codegold79 codegold79 changed the title Back: Make ID types in User service consistent Back: Change ID types in user.proto file to be strings Oct 20, 2019
@codegold79 codegold79 changed the title Back: Change ID types in user.proto file to be strings Back: Change ID types in user.proto file to be strings and user table ID types to be varchar(255) Oct 26, 2019
@daved daved changed the title Back: Change ID types in user.proto file to be strings and user table ID types to be varchar(255) Change ID types in user.proto file to be strings and user table ID types to be varchar(255) Nov 12, 2019
@codegold79 codegold79 mentioned this issue Nov 15, 2019
Merged
@codegold79 codegold79 changed the title Change ID types in user.proto file to be strings and user table ID types to be varchar(255) Change ID types in user.proto file to be strings and user table ID types to be varchar(26) Nov 15, 2019
@daved daved assigned daved and codegold79 and unassigned daved Nov 15, 2019
@codegold79 codegold79 mentioned this issue Nov 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codegold79 codegold79

Labels
end: back
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change user service ID data type OpenEugene/openboard
2 participants
@daved @codegold79