Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #491, issue with part number range check reconstructing chunk off… #498

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Jul 25, 2019

…set table

The chunk offset was incorrectly testing for a part number that was the
same size (i.e. an invalid index)

Signed-off-by: Kimball Thurston kdt3rd@gmail.com

… reconstructing chunk offset table

The chunk offset was incorrectly testing for a part number that was the
same size (i.e. an invalid index)

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Copy link
Contributor

@peterhillman peterhillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdt3rd kdt3rd merged commit 8b5370c into AcademySoftwareFoundation:master Jul 25, 2019
@kdt3rd kdt3rd deleted the fix_491 branch July 25, 2019 08:15
@cary-ilm cary-ilm added this to the v2.4.0 milestone Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants