Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus.io.scrape="false" wherever possible #325

Closed
alexellis opened this issue Nov 16, 2018 · 2 comments · Fixed by #339
Closed

Add prometheus.io.scrape="false" wherever possible #325

alexellis opened this issue Nov 16, 2018 · 2 comments · Fixed by #339
Assignees
@stefanprodan

Comments

@alexellis
Copy link
Member

To follow up to #93 - seems like we missed some key services like NATS which were being scraped in my cluster. We should annotate all services with prometheus.io.scrape="false" to prevent Weave Cloud from attempting to scrape endpoints which do not support this.

cc @stefanprodan
@alexellis
Copy link
Member Author

The same should apply to any microservices inside https://github.com/openfaas/openfaas-cloud

@openfaas openfaas deleted a comment from stefanprodan Dec 18, 2018
@stefanprodan
Copy link
Contributor

Derek assign: me

@stefanprodan stefanprodan mentioned this issue Dec 23, 2018
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanprodan stefanprodan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable Prometheus scraping for components without /metrics
2 participants
@stefanprodan @alexellis