Add flag for kubeconfig override #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to run the faas-netes controller from their local computer when debugging or adding new features. Tested with: go build ; ./faas-netes -kubeconfig=$HOME/.kube/config and a remote cluster which had OpenFaaS installed already. The following command worked as expected: curl -s localhost:8080/system/functions Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
openfaasltd/add-kubeconfig-flag
branch
from
2ca9969
to
e2739c3
Compare
|
@LucasRoesler @stefanprodan FYI this enables local dev/test for faster/easier patches. Thanks to Stefan for putting this into the operator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com
Description
Add flag for kubeconfig override
Motivation and Context
This allows users to run the faas-netes controller from their
local computer when debugging or adding new features.
The Operator codebase already has this.
How Has This Been Tested?
Tested with:
go build ; ./faas-netes -kubeconfig=$HOME/.kube/configand a remote cluster which had OpenFaaS installed already. The
following command worked as expected:
Types of changes