Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix envvar handling in deploy_stack.ps1 #1437

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Fix envvar handling in deploy_stack.ps1 #1437

merged 1 commit into from
Jan 25, 2020

Conversation

johnmccabe
Copy link
Contributor

Description

Adds the missing $env:BASIC_AUTH and $env:AUTH_URL envvars to the windows deploy_stack.ps1 script.

Motivation and Context

Fixes #1308

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Deployed both with and without auth on Windows 10.

With auth - verified by logging in via incognito browser and confirming prompt for basic auth creds.

PS D:\workspace\github\openfaas\faas> powershell -ExecutionPolicy Bypass -File .\deploy_stack.ps1      
Attempting to create credentials for gateway..
[Credentials]
 username: admin
 password: 2a92d6f29b7a70495b9d25519c75b8d2612a9a61784fa56073931867de39f158
 Write-Output "2a92d6f29b7a70495b9d25519c75b8d2612a9a61784fa56073931867de39f158" | faas-cli login --username=admin --password-stdin

Enabling basic authentication for gateway..

Deploying OpenFaaS core services
Creating config func_alertmanager_config
Creating config func_prometheus_config
Creating config func_prometheus_rules
Creating service func_queue-worker
Creating service func_prometheus
Creating service func_alertmanager
Creating service func_gateway
Creating service func_basic-auth-plugin
Creating service func_faas-swarm
Creating service func_nats

With auth - verified by logging in via incognito browser and confirming no prompt for basic auth creds.

PS D:\workspace\github\openfaas\faas> powershell -ExecutionPolicy Bypass -File .\deploy_stack.ps1 -noAuth
Attempting to create credentials for gateway..
[Credentials]
 username: admin
 password: 643b6df63088dacc539fd7150e114de5698ef02b5b7dd87b41c115cc756ef904
 Write-Output "643b6df63088dacc539fd7150e114de5698ef02b5b7dd87b41c115cc756ef904" | faas-cli login --username=admin --password-stdin

Disabling basic authentication for gateway..

Deploying OpenFaaS core services
Creating config func_prometheus_rules
Creating config func_prometheus_config
Creating service func_faas-swarm
Creating service func_queue-worker
Creating service func_prometheus
Creating service func_alertmanager
Creating service func_gateway
Creating service func_basic-auth-plugin

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Adds the missing $env:BASIC_AUTH and $env:AUTH_URL envvars to the
windows deploy_stack.ps1 script.

Signed-off-by: John McCabe <john@johnmccabe.net>
Copy link
Contributor

@rgee0 rgee0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexellis alexellis merged commit e244e5c into openfaas:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of CLI or Web UI returns status code 500 and 'Get : unsupported protocol scheme ""'
3 participants