Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "faasd provider" command #20

Closed
alexellis opened this issue Jan 9, 2020 · 1 comment
Closed

Add "faasd provider" command #20

alexellis opened this issue Jan 9, 2020 · 1 comment

Comments

@alexellis
Copy link
Member

alexellis commented Jan 9, 2020 •
edited

faas and faas-containerd do different jobs but can live as one codebase to reduce overhead. They do have some common concerns such as creating containers/tasks and managing network/IPs with CNI.

Expected Behaviour

Add "faasd start-provider" command which would run the code from faas-containerd, perhaps vendoring it, or just copy/pasting it into a new package and archiving the old repo.

I'd imagine a new file in cmd/ and a new package in pkg/provider/

Current Behaviour

We have two binaries to manage, distribute, test, and update.

Steps / solution

  • Port code into new packages over from faas-containerd into the faasd tree
  • Consolidate documentation and systemd unit files
  • Remove instructions for installing faas-containerd as a separate binary
  • Consolidate any duplicate code
  • Publish a new release of faasd
  • Archive faas-containerd
@carlosedp carlosedp mentioned this issue Jan 20, 2020
Closed
11 tasks
@carlosedp
Copy link
Contributor

Addressing this issue on PR #23

alexellis added a commit that referenced this issue Jan 21, 2020
@alexellis
Initial merge of faas-containerd
7d24ab0 
This patch completes part of the work in #20 by porting the code
for faas-containerd in-tree. When tested, I was able to deploy
and then remove figlet from the store on `x86_64`.

In a follow-up PR, duplication will be removed where possible
and consolidated with updated documentation.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis mentioned this issue Jan 21, 2020
Merged
alexellis added a commit that referenced this issue Jan 21, 2020
@alexellis
Initial merge of faas-containerd
8c7bf70 
This patch completes part of the work in #20 by porting the code
for faas-containerd in-tree. When tested, I was able to deploy
and then remove figlet from the store on `x86_64`.

In a follow-up PR, duplication will be removed where possible
and consolidated with updated documentation.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis added a commit that referenced this issue Jan 21, 2020
@alexellis
Initial merge of faas-containerd
42e9c91 
This patch completes part of the work in #20 by porting the code
for faas-containerd in-tree. When tested, I was able to deploy
and then remove figlet from the store on `x86_64`.

In a follow-up PR, duplication will be removed where possible
and consolidated with updated documentation.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlosedp @alexellis