Add labels to OpenFaas functions from the function spec

[utsavanand2]

Add labels to OpenFaas functions from the function spec

Expected Behaviour

We should be able to add a label to a function by adding it to container definition.

So, when we run:
faas-cli store deploy figlet --label hello=world

We should get back the labels with:
faas-cli describe figlet

Current Behaviour

Labels are not added

Possible Solution

A PR is in the works

Steps to Reproduce (for bugs)

1>faas-cli store deploy figlet --label hello=world
2> faas-cli describe figlet # Won't print out labels

This feature works perfectly with faas-netes (OpenFaas running on Kubernetes), but we need to port this functionality here too.

This issue is a duplicate of this issue by @alexellis on the archived faas-containerd repo

[martindekov]

I can take a look at this 👍

[martindekov]

Derek assign: me

[alexellis]

Thank you 💪

[carlosedp]

Hey @martindekov, I've added some references on the previous issue:

Doc: https://godoc.org/github.com/containerd/containerd#WithContainerLabels

Code:

faasd/pkg/provider/handlers/deploy.go

Line 100 in 4775a9a

container, err := client.NewContainer(

.

[martindekov]

Thanks for pointing the right place @carlosedp 👍 Definitely saved me time searching it 🍻