Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable labeling containers #45

Merged
merged 1 commit into from Feb 23, 2020

Conversation

martindekov
Copy link
Contributor

@martindekov martindekov commented Feb 15, 2020

Enabling the faasd-provider to label containers

Signed-off-by: Martin Dekov mvdekov@gmail.com

Description

Horizontal slice in order to enable labeling containers with the faas-cli and through the UI.

Motivation and Context

  • I have raised an issue to propose this change this is required

Closes #40

How Has This Been Tested?

Deployed figlet through:

  • UI
  • CLI
    with label {"label":"saws"} (not very professional) resulted in this from /system/functions:
[{"name":"figlet","image":"docker.io/functions/figlet:0.13.0","invocationCount":0,"replicas":1,"envProcess":"","availableReplicas":0,"labels":{"label":"saws"},"annotations":null,"namespace":"openfaas-fn"}]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

  • I've read the CONTRIBUTION guide
  • (1/2) My commit message has a body and (NOT THIS) -> describe how this was tested and why it is required.
  • I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.

Docs:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Enabling the faasd-provider to label containers

Signed-off-by: Martin Dekov <mvdekov@gmail.com>
@alexellis alexellis merged commit 560c295 into openfaas:master Feb 23, 2020
@alexellis
Copy link
Member

Thanks. Could you please add an e2e test now? See how we did that for other features.

I guess you can change the deployment of figlet then run faas-cli describe | grep?

@martindekov
Copy link
Contributor Author

I saw the Issue some person had interest in it I will add the test to the file if work hasn't been done by next week 👍

alexellis added a commit that referenced this pull request Sep 11, 2020
Fixes an issue introduced in #45 which was undetected. When
users do not pass in "labels" to the deployment - or a valid
empty object, then a nil defeference causes a panic.

Fixes: #101

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis mentioned this pull request Sep 11, 2020
10 tasks
alexellis added a commit that referenced this pull request Sep 11, 2020
Fixes an issue introduced in #45 which was undetected. When
users do not pass in "labels" to the deployment - or a valid
empty object, then a nil dereference causes a panic.

Fixes: #101

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis added a commit that referenced this pull request Sep 11, 2020
Fixes an issue introduced in #45 which was undetected. When
users do not pass in "labels" to the deployment - or a valid
empty object, then a nil dereference causes a panic.

Fixes: #101

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels to OpenFaas functions from the function spec
2 participants