Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git to cloud-init #161

Merged
merged 1 commit into from
Feb 14, 2021
Merged

add git to cloud-init #161

merged 1 commit into from
Feb 14, 2021

Conversation

Sopor10
Copy link
Contributor

@Sopor10 Sopor10 commented Feb 13, 2021

Description

git is a prerequisite for the cloud-init script.
It's not present by default on every Cloud Provider Image.

Motivation and Context

This fixes Issue #160.

  • I have raised an issue to propose this change this is required

How Has This Been Tested?

I created a faasd Server on Hetzner Cloud.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

  • I've read the CONTRIBUTION guide
  • My commit message has a body and describe how this was tested and why it is required.
  • I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.

Docs:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@derek
Copy link

derek bot commented Feb 13, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: Lars <larslehmann@kabelmail.de>
@derek derek bot removed the no-dco label Feb 13, 2021
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis
Copy link
Member

Approved. You may also want to see our installation script which is in the readme. You can run that from cloud-init and it may be more resilient.

@alexellis alexellis merged commit bc2fe46 into openfaas:master Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants