Fixes #162 Adds Sudo to ipv4 forwarding #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated install.sh to SUDO for /sbin/sysctl -w net.ipv4.conf.all.forwarding=1 this prevents permission issue on ubuntu Signed-off-by: albertkohl-monotek <albert.kohl@mono-tek.com>
|
Sorry, I merged this but assumed you had tested it and didn't realise you hadn't. The template asks "How Has This Been Tested?", can you fill that out, or do we need to revert this? |
|
I’m sorry, I forgot to note, I just made the adjustment and re-ran the install on a fresh vm, and got no errors, and a working app. 😊
…-Albert
From: Alex Ellis <notifications@github.com>
Sent: Thursday, February 18, 2021 3:04 AM
To: openfaas/faasd <faasd@noreply.github.com>
Cc: albertkohl-monotek <albert.kohl@mono-tek.com>; Author <author@noreply.github.com>
Subject: Re: [openfaas/faasd] Fixes #162 Adds Sudo to ipv4 forwarding (#163)
Sorry, I merged this but assumed you had tested it and didn't realise you hadn't.
The template asks "How Has This Been Tested?", can you fill that out, or do we need to revert this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#163 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AORILTZ75VMGSRZD3SIMKELS7TQXHANCNFSM4XZJMH7Q>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated install.sh to SUDO for /sbin/sysctl
-w net.ipv4.conf.all.forwarding=1
this prevents permission issue on ubuntu
Signed-off-by: albertkohl-monotek albert.kohl@mono-tek.com
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Commits:
git commit -sfor the Developer Certificate of Origin (DCO)Code:
Docs: