Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the hostname for containers and functions #166

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

alexellis
Copy link
Member

@alexellis alexellis commented Feb 21, 2021

Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com

Description

Set the hostname for containers and functions

Motivation and Context

By setting the hostname, the container will resolve to its
name instead of just localhost.

How Has This Been Tested?

CI, manual testing to follow

Before:

pi@faasd-pi:~ $ sudo ctr -n openfaas-fn  t exec --exec-id 2398  nodeinfo hostname
faasd-pi

After:

pi@k4s-1:~ $ sudo ctr -n openfaas-fn  t exec --exec-id 22954 nodeinfo hostname
nodeinfo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

By setting the hostname, the container will resolve to its
name instead of just localhost.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis merged commit 6c0f91e into master Feb 21, 2021
@alexellis alexellis deleted the openfaasltd/sethostname branch February 21, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant