Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Uninstall and Stop instruction for faasd #243

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

nitishkumar71
Copy link
Contributor

Signed-off-by: Nitishkumar Singh nitishkumarsingh71@gmail.com

Include stop and complete uninstall instruction

Description

Developer's do not have clear guide to stop and uninstall instruction for faasd

Motivation and Context

How Has This Been Tested?

  1. Install faasd
git clone https://github.com/openfaas/faasd --depth=1
cd faasd

./hack/install.sh
sudo cat /var/lib/faasd/secrets/basic-auth-password | faas-cli login -s
  1. Stop faasd and faasd-provider
sudo systemctl stop faasd
sudo systemctl stop faasd-provider
sudo systemctl stop containerd
sudo rm /usr/lib/systemd/system/faasd-provider.service
sudo rm /usr/lib/systemd/system/faasd.service
sudo systemctl daemon-reload
  1. Remove faasd local binary from machine
sudo rm /usr/local/bin/faasd
  1. Remove additional dependencies.
sudo apt-get remove runc bridge-utils
sudo rm -rf /opt/cni/bin

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

  • I've read the CONTRIBUTION guide
  • My commit message has a body and describe how this was tested and why it is required.
  • I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.

Docs:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

docs/DEV.md Show resolved Hide resolved
docs/DEV.md Show resolved Hide resolved
docs/DEV.md Outdated

* Remove faasd local binary from machine
```
sudo rm /usr/local/bin/faasd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be explicit use rf -rm everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a few tweaks to this please.

@alexellis
Copy link
Member

/set title: Include Uninstall and Stop instruction for faasd

@derek derek bot changed the title Include Unistall and Stop instruction for faasd Include Uninstall and Stop instruction for faasd Feb 21, 2022
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 52f64df into openfaas:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

question: uninstall faasd
2 participants