Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused container client from createTask #264

Merged

Conversation

mohammadVatandoost
Copy link
Contributor

Signed-off-by: mohammadVatandoost mohamadvatandoost512@gmail.com
Signed-off-by: Mohammad Vatandoost mohamadvatandoost512@gmail.com

Description

I removed unused argument from createTask function

Motivation and Context

Clean the code

Types of changes

  • Cleaning the code

Commits:

  • I've read the CONTRIBUTION guide
  • My commit message has a body and describe how this was tested and why it is required.
  • I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.

Docs:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Signed-off-by: mohammadVatandoost <mohamadvatandoost512@gmail.com>
Signed-off-by: Mohammad Vatandoost <mohamadvatandoost512@gmail.com>
@alexellis
Copy link
Member

The automated build passes, so I'll merge this.

Generally, minor refactoring like this that doesn't add value is best left as it creates unnecessary work for us, however, if you're interested in contributing to a project, check out arkade - where we have frequent opportunities for minor changes and additions.

https://github.com/alexellis/arkade

@alexellis alexellis merged commit a574a0c into openfaas:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants