Use faas-cli package for tagging image on OpenFaaS Cloud

[alexellis]

This new package in faas-cli should be used to create image tags for consistency:

https://github.com/openfaas/faas-cli/blob/master/schema/image.go#L17

It should be a relatively quick change.

[viveksyngh]

@alexellis should we vendor faas-cli in openfaas-cloud and use this package to create tag for images?

[viveksyngh]

@alexellis I have made this changes but recently we have merged PR #85 which validates the images name returned from buildshiprun and it's throwing an error for our new image name format.

I may need help from @s8sg for update the regex to validate image name like this
registry:5000/viveksyngh/regex_go-another-go:latest-039ca50585107171bafab71f1d5f65391523cd61 (P.S - I am not a regex expert) or should we disable the image name validation and just check for only 200 response from buildshiprun ?

[s8sg]

Otherwise you can change the regex to match the new image name format. As I told earlier I’m not sure why the image name validation exists

…

On Sun, 29 Jul 2018 at 05:46, Vivek Kumar Singh ***@***.***> wrote: @alexellis <https://github.com/alexellis> I have made this changes but recently we have merged PR #85 <#85> which validates the images name returned from buildshiprun and it's throwing an error for our new image name format. I may need help from @s8sg <https://github.com/s8sg> for update the regex to validate image name like this registry:5000/viveksyngh/regex_go-another-go:latest-039ca50585107171bafab71f1d5f65391523cd61 or should we disable the image name validation and just check for 200 response from buildshiprun ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#87 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHCE6ppA2s5k4w1ncbJM4kGGO2sLH7yMks5uLM2jgaJpZM4VasTr> .

[viveksyngh]

I am removing imageName validation and adding response code based validation for builder response. If response is not 2xx we won't get a valid imageName from builder and that can be used to deteremine if build was successfull or not.

[viveksyngh]

@alexellis looks like image.go from schema package of faas-cli is not part of latest release. Should I use master to vendor that in openfaas-cloud ?

[s8sg]

Can you please check if that check if the image id validation is being done in ofbuilder, And make sure it does gets validated by responses. Otherwise it might open a closed issue

…

On Sun, 29 Jul 2018 at 20:37, Vivek Kumar Singh ***@***.***> wrote: @alexellis <https://github.com/alexellis> looks like image.go from schema package of faas-cli is not part of latest release. Should I use master to vendor that in openfaas-cloud ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#87 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHCE6o9p_ImwmtT5KlIyrzUzwIFTeHrUks5uLZ5dgaJpZM4VasTr> .

[viveksyngh]

as image check regex got merged to master, I will create a PR to add this support.

[alexellis]

Thanks. I've disabled the regex for now. Please PR when you can.