This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 229
[Tested] Use CLI SDK for making openfaas calls #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksyngh
changed the title
Use CLI SDK for making openfaas calls
[WIP] Use CLI SDK for making openfaas calls
Mar 6, 2020
alexellis
reviewed
Mar 6, 2020
alexellis
reviewed
Mar 6, 2020
alexellis
reviewed
Mar 6, 2020
Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
I tested it on my local cluster using k3s and k3d for local development. https://github.com/viveksyngh/openfaas-functions/runs/498663912 buildshiprun function logs
Garbage collect run function
|
viveksyngh
changed the title
[WIP] Use CLI SDK for making openfaas calls
[Tested] Use CLI SDK for making openfaas calls
Mar 10, 2020
@Watetdrips please could you review? |
martindekov
approved these changes
Mar 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Vivek, LGTM. Just wondering why we use fmt
instead of log
? I saw we use fmt in couple of places. Also commented out code can be removed if not used. Those are not blocking though so I approve 👍
Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
martindekov
approved these changes
Apr 1, 2020
alexellis
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, given the testing and approval from @martindekov
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vivek Singh vivekkmr45@yahoo.in
Description
How Has This Been Tested?
buildshiprun and garbage collect part of #609
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
git commit -s