This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Make Github Status namespace checks by APP ID #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Github Status function was not namespacing the check-runs. It was using the same ting for each installed app. This has been changed to namespace by app_id. This means that 2 + installations on the same repository can now correctly create & report github check runs. This has been tested by installing 2x OCF installations, then running a pipeline. This failed of half of the functions as they didn't get the correct check for that app. Then I added the new function to each OFC installation, and re-ran a pipeline. Every check run was created and reported back correctly. Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
alexellis
reviewed
May 11, 2020
| if os.Getenv("use_checks") == "false" { | ||
| return reportStatus(commitStatus.Status, commitStatus.Description, commitStatus.Context, event) |
There was a problem hiding this comment.
What kind of value was in commitStatus.Context before vs the static GitHub app ID?
There was a problem hiding this comment.
https://developer.github.com/v3/repos/statuses/
context | string | A string label to differentiate this status from the status of other systems. Default: default
default was always the value
There was a problem hiding this comment.
OK, so did you pick the GitHub app ID because it should be unique between installations? It could be any identifier as long as it is consistent?
There was a problem hiding this comment.
Yeh, and its already included in the image as an env var
|
@alexellis any thoughs on merging this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Github Status function was not namespacing the check-runs. It was
using the same ting for each installed app. This has been changed to
namespace by app_id. This means that 2 + installations on the same
repository can now correctly create & report github check runs.
Fixes #540
Signed-off-by: Alistair Hey alistair@heyal.co.uk
How Has This Been Tested?
This has been tested by installing 2x OCF installations, then running a
pipeline. This failed of half of the functions as they didn't get the
correct check for that app.
Then I added the new function to each OFC installation, and re-ran a
pipeline. Every check run was created and reported back correctly.
How are existing users impacted? What migration steps/scripts do we need?
Users with more than 1 app installed can correctly get statuses back from the OFC installations.
Checklist:
I have:
git commit -s