This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Vendor SDK for function-logs #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a comment on the wrapping of the commit message. What width are you using as a template? It seems too narrow. |
|
@martindekov FYI I think the testing of the build logs may be irrelevant here since they are not using the OpenFaaS REST API, they are simply the output of the of-builder service. Can you confirm if that's your understanding too? |
alexellis
reviewed
Mar 15, 2020
|
I will need to re-visit this change as per your comment. |
|
Thanks Martin |
martindekov
force-pushed
the
martindekov/vendor-function-logs
branch
from
b77b36c
to
a0ccde9
Compare
viveksyngh
reviewed
Mar 26, 2020
Vendor faas-cli SDK for function logs instead of creating custom http requests. Also rewriting unit tests and removing excess error handling which is moved in the SDK and is excessive as we don't parse JSON into the function anymore Signed-off-by: Martin Dekov <mvdekov@gmail.com>
martindekov
force-pushed
the
martindekov/vendor-function-logs
branch
from
a0ccde9
to
5fded2f
Compare
viveksyngh
approved these changes
Apr 1, 2020
alexellis
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor faas-cli SDK for function logs
instead of creating custom http requests.
Also rewriting unit tests and removing
excess error handling which is moved in
the SDK and is excessive as we don't
parse JSON into the function anymore
Signed-off-by: Martin Dekov mvdekov@gmail.com
Description
Part of #609
How Has This Been Tested?
On my own private instance with image containing the change
martindekov/function-logs:0.3.0-rc3:functions/function-logs:0.0.2commit log output:https://github.com/martindekov/push2/runs/509201597
martindekov/function-logs:0.3.0-rc3commit log output:https://github.com/martindekov/push2/runs/509210079
UI's
Build Logswith same image:How are existing users impacted? What migration steps/scripts do we need?
N/A Internal change
Checklist:
I have:
git commit -s