This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Add Cookie root domain env variable to Dashboard #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhere along the line the cookie_root_domain was missed from the dashboard config. This only needs to be set when using OAuth, to remove a users token from their cookie. This was not set and therefore caused us to try and set the cookie domain to "undefined" This has been tested by adding the env to the Dashboard deployment and hitting logout on an OAuth enabled installation. This now sets the correct cookie domain and removes the existing token Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
alexellis
reviewed
May 11, 2020
| query_pretty_url: 'true' | ||
| # Cookie root domain, set is using OAuth, used to remove a user's cookie | ||
| cookie_root_domain: 'system.o6s.io' |
There was a problem hiding this comment.
This is templated, so wouldn't this need to be changed in ofc-bootstrap rather than here?
There was a problem hiding this comment.
This needs to be synced here -> https://github.com/openfaas-incubator/ofc-bootstrap/blob/master/templates/dashboard_config.yml
There was a problem hiding this comment.
Yeh, it will need changing there. The ones in that yaml looked like "example" settings so I added there for future reference.
There was a problem hiding this comment.
|
Happy to merge, but wouldn't this need to be changed in ofc-bootstrap? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Somewhere along the line the cookie_root_domain was missed from the
dashboard config. This only needs to be set when using OAuth, to remove
a users token from their cookie. This was not set and therefore caused
us to try and set the cookie domain to "undefined"
Signed-off-by: Alistair Hey alistair@heyal.co.uk
Fixes #632
How Has This Been Tested?
This has been tested by adding the env to the Dashboard deployment and
hitting logout on an OAuth enabled installation. This now sets the
correct cookie domain and removes the existing token
How are existing users impacted? What migration steps/scripts do we need?
This is a bugfix, users will need to edit their dashboard deployment to add this environment variable
and add the following to the environment variables section:
(example where your openfaas root domain is "example.com"
Checklist:
I have:
git commit -sThis will also need amending in ofc-bootstrap to propagate this change