This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Add support for limited build-args for Go modules #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for go modules is now active in git-tar and of-builder. Tested on the community cluster with new images and the following sample repo: https://github.com/alexellis/gitops-webinar Fixes: #652 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
changed the title
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com
Description
Add support for limited build-args
Support for go modules is now active in git-tar and of-builder.
Fixes: #652
How Has This Been Tested?
Tested on the community cluster with new images and the
following sample repo:
https://github.com/alexellis/gitops-webinar
How are existing users impacted? What migration steps/scripts do we need?
git-tar and of-builder both need an update, but they can be updated separately. A release is also required from this repo for use with ofc-bootstrap.
Checklist:
I have:
git commit -s