This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Update chart namespaces to match existing #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alexellis
reviewed
Oct 15, 2020
Waterdrips
force-pushed
the
waterdrips-fix-chart-namespaces
branch
2 times, most recently
from
c9d1c12
to
7cee527
Compare
The namespaces in the chart were wrong or missing for a lot of the resources. These have now been corrected along with adding the annotation for ingress shim for cert-manager to get tls for domains if they are asked for Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Waterdrips
force-pushed
the
waterdrips-fix-chart-namespaces
branch
from
7cee527
to
973f68e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The namespaces in the chart were wrong or missing for a lot of
the resources. These have now been corrected along with adding the
annotation for ingress shim for cert-manager to get tls for domains if
they are asked for
Signed-off-by: Alistair Hey alistair@heyal.co.uk
How Has This Been Tested?
Unit tests