Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fga model write second example doesn't work #291

Closed
miparnisari opened this issue Apr 5, 2024 · 4 comments · Fixed by #295
Closed

fga model write second example doesn't work #291

miparnisari opened this issue Apr 5, 2024 · 4 comments · Fixed by #295

Comments

@miparnisari
Copy link
Member

miparnisari commented Apr 5, 2024

On fga version v0.3.0(commit:22466ca, date: 2024-03-28T21:40:05Z)

  • help text is odd, see below
  • the second example doesn't work, it needs --format json
image
@ewanharris
Copy link
Member

The ModelFormat text is because that's what we return in the Type function, maybe we should just return format as I think in an enum based option a lowercase of the option is more common, wdyt @miparnisari?

The default default I'm not sure what we can do about that as the default for that default. I think maybe we could refactor the code to remove that and potentially use an empty string value in place of default but that might be a bit more involved.

@miparnisari
Copy link
Member Author

The ModelFormat text is because that's what we return in the Type function, maybe we should just return format as I think in an enum based option a lowercase of the option is more common, wdyt @miparnisari?

Why not put type string?

use an empty string value in place of default

Based on the example that i tried, it looks like the default is fga

@rhamzeh
Copy link
Member

rhamzeh commented Apr 11, 2024

Based on the example that i tried, it looks like the default is fga

The default depends - it's either fga if you paste the string directly, or autodetected from the file name if you pass in the file

@rhamzeh
Copy link
Member

rhamzeh commented Apr 11, 2024

Why not put type string?

It's not a string though - it's an enum, you can't say yaml for example.

@github-project-automation github-project-automation bot moved this from Backlog to Done in SDKs and Tooling Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants