Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Remove if true from the models #11

Closed
rhamzeh opened this issue Apr 11, 2023 · 0 comments · Fixed by openfga/sdk-generator#211
Closed

Code Quality: Remove if true from the models #11

rhamzeh opened this issue Apr 11, 2023 · 0 comments · Fixed by openfga/sdk-generator#211
Labels
good first issue Good for newcomers

Comments

@rhamzeh
Copy link
Member

rhamzeh commented Apr 11, 2023 •
edited
Loading

Our current models in the SDK Generator lead to a lot of if true statements (see: https://github.com/openfga/go-sdk/blob/main/model_authorization_model.go#L137).

We should update the generator to remove these statements.

Note that this change MUST be made in the generator templates https://github.com/openfga/sdk-generator/tree/main/config/clients/go/template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust logic on handlebars to avoid 'if true' statement on models gabrielbussolo/sdk-generator
1 participant
@rhamzeh