Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value of B2Mat22 is probably wrong #11

Closed
boblucas opened this issue Sep 28, 2015 · 1 comment
Closed

Default value of B2Mat22 is probably wrong #11

boblucas opened this issue Sep 28, 2015 · 1 comment

Comments

@boblucas
Copy link

class B2Mat22
{
    public function new ()
    {
        col1 = new B2Vec2(0, 1.0);
        col2 = new B2Vec2(0, 1.0);
    }
}

This would initialize the matrix in a way that when used as a transform results in a width of 0, which is hardly ever useful. I'd except it to be initialized as such:

class B2Mat22
{
    public function new ()
    {
        col1 = new B2Vec2(1.0, 0);
        col2 = new B2Vec2(0, 1.0);
    }
}
@jgranick
Copy link
Member

Thanks, good catch! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants