Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the broadcast events for attempts and runs on History page #1284

Closed
taylordowns2000 opened this issue Nov 6, 2023 · 1 comment · Fixed by #1309
Closed

Update the broadcast events for attempts and runs on History page #1284

taylordowns2000 opened this issue Nov 6, 2023 · 1 comment · Fixed by #1309
Assignees
Labels
bug Newly identified bug

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Nov 6, 2023

@elias-ba and @midigofrank point out that attempt and run events are not being handled properly by the new history page.

c413bd5#diff-d83c666728f5ede80de9e0fa0c0576415368d56bac060201ef1452f2df53728aR118-R119

While we're at it, we can use this issue to track all the events we expect to handle:

  1. new workorder should create a new row in the list (assuming it matches the current filters)
  2. attempt:created should create a new attempt
  3. attempt:updated should update an attempt
  4. run:created should create a new run
  5. run:updated should update a run
@taylordowns2000 taylordowns2000 added the bug Newly identified bug label Nov 6, 2023
@midigofrank midigofrank self-assigned this Nov 8, 2023
@midigofrank
Copy link
Collaborator

@taylordowns2000 @NickOpenFn , how should we handle the first point?

new workorder should create a new row in the list (assuming it matches the current filters)

If we refetch all workorders every time a new workorder is created, there's a chance that a workorder which was being monitored by the user will get lost. This will only happen if 10 new workorders come in, because of our page size.

If we append the new workorder, which is what I'm doing currently, when the user clicks to move to the next page, they will get some results from the previous page.

What do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants