Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect wording on the "Delete" tooltip #1313

Closed
NickOpenFn opened this issue Nov 8, 2023 · 1 comment · Fixed by #1345
Closed

Incorrect wording on the "Delete" tooltip #1313

NickOpenFn opened this issue Nov 8, 2023 · 1 comment · Fixed by #1345
Assignees

Comments

@NickOpenFn
Copy link

NickOpenFn commented Nov 8, 2023

https://www.loom.com/share/bdf8e541b9684ce4a9f7fe80ba4cba93?sid=39d85564-2820-4509-a178-65e7792779de

Currently you can't delete the first job in the workflow (which is correct).
The delete button is disabled in this case, with correct wording.

You can delete the last jobs of an edge (which is correct).

You can't delete jobs that are in the middle of the workflow (not the first, nor the last jobs) (which is correct).
However, the tooltip when hovering on the button to delete it (which is correctly disabled) is incorrect since it's using the same wording as the tooltip when hovering on the disabled button of the first job.

Correct wording should be for any node that can't be deleted since it's in the middle of the workflow:
"This job cannot be deleted as it has downstream jobs associated with it."

@elias-ba elias-ba self-assigned this Nov 9, 2023
@NickOpenFn
Copy link
Author

@elias-ba Let's improve the wording for the tooltips here too:

  • "This job cannot be deleted as it has downstream jobs associated with it."
  • "The initial job of a workflow cannot be deleted."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants