Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow attempt to complete before started #1379

Closed
stuartc opened this issue Nov 14, 2023 · 0 comments · Fixed by #1381
Closed

Allow attempt to complete before started #1379

stuartc opened this issue Nov 14, 2023 · 0 comments · Fixed by #1381
Assignees
@stuartc

Comments

@stuartc
Copy link
Member

stuartc commented Nov 14, 2023 •
edited
Loading

The worker can fail before an attempt is started, we should remove the validation preventing this.
@stuartc stuartc assigned stuartc and unassigned stuartc Nov 14, 2023
stuartc added a commit that referenced this issue Nov 14, 2023
@stuartc
Allow claimed to final state on attempts
c083c6b 
- Relax the requirement that an attempt must be started before being
  marked as errored. The worker can fail before starting an attempt.
- Put all the state transition validations into one function

Closes: #1379
@stuartc stuartc mentioned this issue Nov 14, 2023
Merged
4 tasks
stuartc added a commit that referenced this issue Nov 14, 2023
@stuartc
Allow claimed to final state on attempts
c7eac03 
- Relax the requirement that an attempt must be started before being
  marked as errored. The worker can fail before starting an attempt.
- Put all the state transition validations into one function

Closes: #1379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartc stuartc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow attempt to be marked as failed before started OpenFn/lightning
1 participant
@stuartc