Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ai-chat user permission check to policies/users.ex #2405

Closed
taylordowns2000 opened this issue Aug 20, 2024 · 1 comment
Closed

Move ai-chat user permission check to policies/users.ex #2405

taylordowns2000 opened this issue Aug 20, 2024 · 1 comment

Comments

@taylordowns2000
Copy link
Member

It looks like there's a permissions check inside the ai_assistant.ex module, which would be a no-no. Even though #2296 will remove this superuser check, we should make sure that whatever permissions are applied to the ai-chat service are handled properly: likely by adding the new actions to the policies/project_users.ex file.

image
@taylordowns2000 taylordowns2000 mentioned this issue Aug 20, 2024
Closed
2 tasks
@taylordowns2000
Copy link
Member Author

hey is this done @christad92 ? i see that the permissions check is still in ai_assistant.ex rather than as described in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
v2
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christad92 @taylordowns2000