Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove errors on Proof card emits #455

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Mar 16, 2024

What

Errors in the console regarding ProofCard

  • fixed by adding the emits param to the component
  • improved the wording

Screenshot

image

@raphodn raphodn force-pushed the raphodn/components-emits-proof-fix branch from 8b3948c to a044026 Compare March 16, 2024 13:21
@raphodn raphodn requested a review from dq18 March 16, 2024 13:21
@raphodn raphodn merged commit 3cdd81c into master Mar 16, 2024
2 checks passed
@raphodn raphodn deleted the raphodn/components-emits-proof-fix branch March 16, 2024 13:21
@@ -35,6 +37,7 @@ export default {
selectedProof: null,
}
},
emits: ['recentProofSelected', 'close'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something to add in other components as well (in another refactoring PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant