Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fields clickable on product page #31

Closed
teolemon opened this issue Apr 16, 2016 · 10 comments
Closed

Make fields clickable on product page #31

teolemon opened this issue Apr 16, 2016 · 10 comments

Comments

@teolemon
Copy link
Member

One of the killer things on Open Food Facts web version is being able to browse from product to product by clicking on the fields (eg: Poissons panés or Findus)
It would be great to leverage the new API by letting users navigate using the App

@teolemon
Copy link
Member Author

The idea is more than having popups. It would be moving to a whole new view, much like we do on the web.

@teolemon teolemon added this to the product-browsing milestone May 8, 2016
@teolemon teolemon added the easy fix Easily fixable issues, good for first timers label Sep 28, 2016
@herau
Copy link
Contributor

herau commented Oct 7, 2016

@teolemon can you have a more detail specification ?
If i select a field from a product, then we should display only a list view with all associated products ? or a more complicated view, like in openfoodfacts website, with sometimes a nutritional summary of all products

@teolemon
Copy link
Member Author

teolemon commented Oct 7, 2016

This depends on #66

@teolemon
Copy link
Member Author

teolemon commented Oct 7, 2016

in a first iteration, just all products with the criteria, and then we could add the averages…
It's a view reading the associated JSON.
So say the product has E301, on clicking it would display a new view with a list of product from http://world.openfoodfacts.org/additive/e301-sodium-ascorbate.json

@teolemon
Copy link
Member Author

teolemon commented Oct 7, 2016

Having more complex view for some criteria present challenges like location (perhaps adding a map), categories (adding a table with the averages, which should be present in the JSON)…

@teolemon
Copy link
Member Author

teolemon commented Oct 7, 2016

Also, we can imaging letting the user combine criteria just like on the web, but it's not a priority.

@herau
Copy link
Contributor

herau commented Oct 7, 2016

ok i get it. i will working on #66

@teolemon teolemon removed the easy fix Easily fixable issues, good for first timers label Dec 21, 2016
@teolemon
Copy link
Member Author

teolemon commented Jan 22, 2017

#66 closed.
The simple way would be to reuse the view created for search, using the various jsons.
http://world.openfoodfacts.org/additives.json
http://world.openfoodfacts.org/additive/e301-sodium-ascorbate.json

@Karljoones
Copy link
Member

I am going to close this as you have split it into individual issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants