Quality facet - Nutrition - list products where serving size can't be parsed

[CharlesNepote]

What

Serving size has a specific goal: to let Open Food Facts app make a proportional calculation of each nutrient per serving size -- see: https://en.wiki.openfoodfacts.org/Data_fields

But dozens of "serving_size" values can't be parsed. Examples: 30 gr, 2 liters, 60, 9 candies and 2 biscuits and son on.

We should have a new quality facet to list each product where serving_size (and quantity?) has a value that can't be parsed.

Part of

• 🧽 Data quality (tracker) #5538

[stephanegigandet]

For quantity we have one: https://world.openfoodfacts.org/data-quality/quantity-not-recognized

[CharlesNepote]

For quantity we have one: https://world.openfoodfacts.org/data-quality/quantity-not-recognized

Thanks. 14,342 products on 2020-03-21.

Reminder for further investigation:

• normalize_quantity function [only used for imports??? not used when users manually enter new products?]
• the unit tests for normalize_quantity function
• the quantity-not-recognized facet code

[github-actions]

Stale issue message

[benbenben2]

Is this still needed?

Thanks to Mirabelle, now we have such list:

https://mirabelle.openfoodfacts.org/products?sql=SELECT+count%28*%29+AS+row_count%2C+serving_size%2C+serving_quantity+from+%5Ball%5D%0D%0AWHERE+serving_size+%21%3D+%22%22+AND+%28serving_quantity+IS+NULL+OR+serving_quantity+%3D+0.0%29+%0D%0AGROUP+BY+serving_size%2C+serving_quantity%0D%0A

[alexgarel]

@benbenben2 I think it's good to have it as a facet however.

[benbenben2]

@alexgarel @CharlesNepote @stephanegigandet
For this Input:

We get this:

Whereas for this input:

We get this:

and this:

This " Nutrition data per serving - Serving quantity is 0 " facet, has been introduced by @stephanegigandet , before the creation of this current issue.

On the other hand, another example: https://world.openfoodfacts.org/product/3322680001236/12-crepes-de-landerneau-le-ster


And there is not error regarding serving quantity.

So, this is a little bit misleading because this error is raised when there is actually no serving quantity defined. And there is no error raised when serving quantity is 0.

What do you want to do there?

• rename error and include both cases: 0 and not defined, "serving quantity not recognized"
• have 2 separate errors (1 for 0 and 1 for not defined)
• something else

[stephanegigandet]

We should have 3 different errors I think :)

• Nutrition data per serving - Serving quantity is unknown
• Nutrition data per serving - Serving quantity is not recognized
• Nutrition data per serving - Serving quantity is 0 --> only when we actually get "0 g" or similar