feat: updated test for serving_size for nutrition table #8685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧬 Taxonomies
|
Kudos, SonarCloud Quality Gate passed!
|
alexgarel
approved these changes
Jul 12, 2023
Comment on lines
+572
to
+586
| check_quality_and_test_product_has_quality_tag( | ||
| $product_ref, | ||
| 'en:nutrition-data-per-serving-missing-serving-size', | ||
| 'serving size should be provided if "per serving" is selected', 0 | ||
| ); | ||
| check_quality_and_test_product_has_quality_tag( | ||
| $product_ref, | ||
| 'en:nutrition-data-per-serving-serving-quantity-is-0', | ||
| 'serving size equal to 0 is unexpected', 0 | ||
| ); | ||
| check_quality_and_test_product_has_quality_tag( | ||
| $product_ref, | ||
| 'en:nutrition-data-per-serving-serving-quantity-is-not-recognized', | ||
| 'serving size cannot be parsed', 1 | ||
| ); |
There was a problem hiding this comment.
When I see we reapeat the test 3 times, shan't we change check_quality_and_test_product_has_quality_tag to have a list of tags to check for presence, and a list of tags to check for absence ?
Of course in another PR.
|
Very good! Thanks a lot @benbenben2 this is far more clear and useful as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder: serving_size is the input from the contributor, serving_quantity is the extracted quantity from the serving_size
Nutrition data per serving - Serving quantity is unknown
Nutrition data per serving - Serving quantity is not recognized
Nutrition data per serving - Serving quantity is 0 --> only when we actually get "0 g" or similar
would be exact same as: en:nutrition-data-per-serving-missing-serving-size
previously it was a warning
updated to be an error
Remark about 2 & 3)
Reason is that normalize_serving_size subroutine in Units.pm returns 0 if it cannot extract the serving otherwise it returns the result of the subroutine unit_to_g, and this latter return either something or nothing (i.e., not 0)
(new) en:nutrition-data-per-serving-serving-quantity-is-not-recognized
This covers both cases:
2)a) Serving quantity is not recognized - but regex did work) and
2)b) Serving quantity is not recognized - and regex to extract "quantity" and "unit" does not work
This should never be 0
en:nutrition-data-per-serving-serving-quantity-is-0
For "0 g" or "0 mL"
(from feat: add data quality warning for serving size without digit #8057) en:Nutrition data per serving - Serving size is missing digits
tested locally:
input - result
10 ml - ok
empty - 1
serving - 2 and 4
0g - 3
0 mL - 3