Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW DESIGN: Sign-in button does not work on product page: empty modal #7464

Closed
stephanegigandet opened this issue Oct 10, 2022 · 0 comments
Closed

NEW DESIGN: Sign-in button does not work on product page: empty modal #7464

stephanegigandet opened this issue Oct 10, 2022 · 0 comments
Labels
🐛 bug This is a bug, not a feature request. modals 👥 User management

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Oct 10, 2022 •
edited by teolemon
Loading

What

  • We try to open a modal on sign-in, but only on product pages it seems.

<a href="/cgi/session.pl" data-reveal-id="loginmodal" class="round button secondary">
Should probably just remove the data-reveal-id

Part of
@stephanegigandet stephanegigandet mentioned this issue Oct 10, 2022
Open
stephanegigandet added a commit that referenced this issue Oct 10, 2022
@stephanegigandet
fix footer + sign-in button on product page #7464
c1157bc
@stephanegigandet stephanegigandet mentioned this issue Oct 10, 2022
Merged
stephanegigandet added a commit that referenced this issue Oct 10, 2022
@stephanegigandet
fix: put footer at the bottom of the page + sign-in button on product…
e8b970e 
… page (#7466)

* fix: put footer at the bottom #7410

* fix footer + sign-in button on product page #7464

* fix footer buttons
@teolemon teolemon added 🐛 bug This is a bug, not a feature request. 👥 User management modals labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug This is a bug, not a feature request. modals 👥 User management
Projects
Getting the new web design to the next level
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @stephanegigandet