Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW DESIGN: Improve footer for pages smaller than the screen #7410

Closed
Tracked by #7295
stephanegigandet opened this issue Sep 28, 2022 · 5 comments
Closed
Tracked by #7295

NEW DESIGN: Improve footer for pages smaller than the screen #7410

stephanegigandet opened this issue Sep 28, 2022 · 5 comments
Assignees
@stephanegigandet
Labels
CSS 🎨 Design good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Hacktoberfest 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign.

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Sep 28, 2022 •
edited by teolemon
Loading

What

  • When there is little content on the page and the screen is large, the footer is not at the bottom of the page.
  • Ideally: set some min-height parameter according to user's screen size, or some meaningful default min-height.
  • At the minimum: put a dark background below the footer for the rest of the page.

Part of

Current situation

image
@stephanegigandet stephanegigandet mentioned this issue Sep 28, 2022
Open
@yashfalke77
Copy link

hey @stephanegigandet can i work on this issue?

@teolemon teolemon added 🎨 Design 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. labels Sep 28, 2022
@sdeepanshu17
Copy link

Hey, Can I work on this issue?

@stephanegigandet
Copy link
Contributor Author

Hi @yashfalke77 and @sdeepanshu17 , thanks for volunteering. :) Maybe @sdeepanshu17 can try this one, as you already have another bug assigned to you @yashfalke77 . Please don't hesitate to suggest ways to fix this in comments etc. Thank you!

This bug is on the new "redesign2" branch, there is more details on how to deploy / test etc. in this meta bug: #7295

@teolemon teolemon added the good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. label Oct 10, 2022
@stephanegigandet stephanegigandet self-assigned this Oct 10, 2022
stephanegigandet added a commit that referenced this issue Oct 10, 2022
@stephanegigandet
fix: put footer at the bottom #7410
8f32fe7
@stephanegigandet stephanegigandet mentioned this issue Oct 10, 2022
Merged
stephanegigandet added a commit that referenced this issue Oct 10, 2022
@stephanegigandet
fix: put footer at the bottom of the page + sign-in button on product…
e8b970e 
… page (#7466)

* fix: put footer at the bottom #7410

* fix footer + sign-in button on product page #7464

* fix footer buttons
@jainshubham766
Copy link

Please assign me this issue

@teolemon
Copy link
Member

@jainshubham766 This has been fixed by @stephanegigandet it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanegigandet stephanegigandet

Labels
CSS 🎨 Design good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Hacktoberfest 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign.
Projects
Getting the new web design to the next level
Archived in project
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@teolemon @stephanegigandet @sdeepanshu17 @jainshubham766 @yashfalke77