Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always display contribution panel after edit #8745

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: always display contribution panel after edit #8745

merged 1 commit into from
Jul 28, 2023

Conversation

alexgarel
Copy link
Member

fixes: #8294

@alexgarel alexgarel requested a review from a team as a code owner July 27, 2023 15:31
@codecov-commenter
Copy link

Codecov Report

Merging #8745 (d250059) into main (b128504) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8745   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files         117      117           
  Lines       21882    21882           
  Branches     4869     4869           
=======================================
  Hits        10676    10676           
  Misses       9903     9903           
  Partials     1303     1303

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MonalikaPatnaik
Copy link
Collaborator

LGTM👌

@alexgarel alexgarel merged commit 35a1666 into main Jul 28, 2023
15 checks passed
@alexgarel alexgarel deleted the fix-display-contribution-panel-on-edit branch July 28, 2023 08:46
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonalikaPatnaik MonalikaPatnaik MonalikaPatnaik approved these changes

@albatrousse albatrousse Awaiting requested review from albatrousse

Assignees

@alexgarel alexgarel

Labels
None yet
Projects
old prs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data quality knowledge panel is not displayed when there are no errors
3 participants
@alexgarel @codecov-commenter @MonalikaPatnaik