Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: spices and sauces updates #8777

Merged
merged 30 commits into from
Aug 23, 2023
Merged

Conversation

OpenChris
Copy link
Contributor

@OpenChris OpenChris commented Aug 1, 2023

• add Aniseed alias to Anise, proxy to Fennel same plant as green anise
• add Glutamate as a Flavour enhancers
• add "Roux" butter + flour sauces
• link Yakitori sauces to Soy sauces (and get proper Ciqual)
• add Sukiyaki sauces
• add Fish broth to dehydrated broths
• use cooked beetroot as proxy for preserved beetroot
• add dried Chives
• add dried dill
• add dried tarragon
• add mustard seeds as a spice
• add lemon and lime juice concentrates - Proposal : proxy lime juice to lemon juice instead of lime pulp (slightly lower score, more coherent with the pulp-->juice score decrease observed on lemon)
• add English translation to filets de canard
• fix typo on English name for frozen cooked snails : (the snail is cooked, not just the sauce)
• add frozen snails with parsley butter
• add Frozen baguettes under Baguettes
• proxy white asparagus to peeled white asparagus
• proxy all "pâte pressée non cuite" cheeses to existing "Saint Paulin" Agrib.
• remove duplicate entry "stuffings"
• add "frozen" under "vegetable gratins"

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Aug 1, 2023
@aleene
Copy link
Contributor

aleene commented Aug 1, 2023

I suspect that glutamate is already in the additives section (separate file) of the ingredients. So no need to add it.

@OpenChris
Copy link
Contributor Author

Why would this be different from say "Apples" that are both an ingredient and a category of packaged products?
We would need a category for these products, wouldn't we?

@aleene
Copy link
Contributor

aleene commented Aug 2, 2023

Indeed an ingredient and category can be the same for single ingredient products (this fact is not yet leveraged by the way).

The ingredients are split over multiple files, as some require special processing (legal and regulation). Ingredients.txt is the main one, specials are additives, vitamins, minerals and some others. If all is well there are no duplicates ingredients between those files.

@OpenChris
Copy link
Contributor Author

Thanks, so how would you name the category for these packaged products: 6901104158113, 8850464000311 or 8850464000083?
I suggest either:

  1. Glutamate
  2. Monosodium glutamate

taxonomies/categories.txt Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #8777 (d220006) into main (a801922) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8777   +/-   ##
=======================================
  Coverage   45.54%   45.54%           
=======================================
  Files          64       64           
  Lines       19519    19519           
  Branches     4738     4738           
=======================================
  Hits         8889     8889           
  Misses       9454     9454           
  Partials     1176     1176           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 35bf44a into main Aug 23, 2023
14 checks passed
@stephanegigandet stephanegigandet deleted the openchris-taxonomies branch August 23, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants