feat: make valid org filter field a dropdown #10524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Template::Toolkit
TheSussex
changed the title
alexgarel
reviewed
Jul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10524 +/- ##
==========================================
- Coverage 49.54% 49.27% -0.28%
==========================================
Files 67 76 +9
Lines 20650 21863 +1213
Branches 4980 5235 +255
==========================================
+ Hits 10231 10772 +541
- Misses 9131 9769 +638
- Partials 1288 1322 +34 ☔ View full report in Codecov by Sentry. |
alexgarel
approved these changes
Jul 9, 2024
| <label for="valid_org">[% lang("verified_status") %]:</label> | ||
| <input type="text" id="valid_org" name="valid_org" value="[% valid_org | html %]"> | ||
| <select id="valid_org" name="valid_org"> | ||
| <option value="unreviewed" [% IF valid_org == 'unreviewed' %]selected[% END %]>Unreviewed</option> |
There was a problem hiding this comment.
We should add an option for the case of no selection:
Suggested change
| <option value="unreviewed" [% IF valid_org == 'unreviewed' %]selected[% END %]>Unreviewed</option> | |
| <option value="" [% IF !(valid_org) %]selected[% END %]></option> | |
| <option value="unreviewed" [% IF valid_org == 'unreviewed' %]selected[% END %]>Unreviewed</option> |
stephanegigandet
pushed a commit
that referenced
this pull request
Jul 23, 2024
🤖 I have created a release *beep* *boop* --- ## [2.38.0](v2.37.0...v2.38.0) (2024-07-23) ### Features * add new product event types for redis queue ([#10530](#10530)) ([339dbc4](339dbc4)) * add product data to org table ([#10534](#10534)) ([dce0518](dce0518)) * added a drag and drop zone in pro platform ([#10569](#10569)) ([ce60b8f](ce60b8f)) * allow orgs to not have a main contact if imported from an aggregator ([#10531](#10531)) ([ead1b0c](ead1b0c)) * launch the exports for all organizations that have the checkbox… ([#10561](#10561)) ([c3aa2d1](c3aa2d1)) * Lint spaces in taxonomies ([#10563](#10563)) ([c01cf91](c01cf91)) * make valid org filter field a dropdown ([#10524](#10524)) ([b38e62c](b38e62c)) * measure and log duration of request and mongodb / off-query que… ([#10557](#10557)) ([2cb1b1e](2cb1b1e)) * packaging add Ireland ([#10533](#10533)) ([3f3196e](3f3196e)), closes [#1572](#1572) ### Bug Fixes * add product_type to redis events ([#10550](#10550)) ([6bd1c0e](6bd1c0e)) * added barcode-svg ([#10242](#10242)) ([8da89da](8da89da)) * broken user space on pro platform ([#10541](#10541)) ([b6e3017](b6e3017)) * change_main_contact.pl ([#10548](#10548)) ([b2f90ea](b2f90ea)) * disable caching on pro platform ([#10516](#10516)) ([4ccd714](4ccd714)) * GDSN import from Alnatura ([#10556](#10556)) ([6e2673a](6e2673a)) * improve generated data for a .pl script ([#10532](#10532)) ([1cab04c](1cab04c)) * pro_moderator_owner not stored for the admin/moderator user through org/[orgid] facet ([#10560](#10560)) ([e0441c6](e0441c6)) * rate limiter log config ([#10535](#10535)) ([9a5168d](9a5168d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Made the verified status filter on organisation table a dropdown
Screenshot
Related issue(s) and discussion