Remove the /lang directory

[teolemon]

What

• Remove the /lang directory since I added the missing files to the new static repository: openfoodfacts/openfoodfacts-web@5ac85c8
• Move those tests to openfoodfacts-web

#   Failed test 'footer_legal_link link - lang: pt - textid: informacao-legal -- file /lang/pt/texts/informacao-legal.html does not exist'
#   at t/lang.t line 52.

#   Failed test 'footer_legal_link link - lang: fr - textid: mentions-legales -- file /lang/fr/texts/mentions-legales.html does not exist'
#   at t/lang.t line 52.

#   Failed test 'footer_terms_link link - lang: fr - textid: conditions-d-utilisation -- file /lang/fr/texts/conditions-d-utilisation.html does not exist'
#   at t/lang.t line 52.

#   Failed test 'footer_terms_link link - lang: pt - textid: termos-de-utilizacao -- file /lang/pt/texts/termos-de-utilizacao.html does not exist'
#   at t/lang.t line 52.
# Looks like you failed 4 tests of 376.
t/lang.t ......................... 

Part of

• Static content

[hangy]

How do you want to integrate this into develpoment environments, ie. Docker? Also, the GitHub workflows will need to be fixed. For example, the PR validation does try to build language (I assume to validate the translations):

openfoodfacts-server/.github/workflows/pull_request.yml

Line 166 in f33510e

perl -CS -I$BUILD_DIR/lib $BUILD_DIR/scripts/build_lang.pl

[stephanegigandet]

@hangy : if we leave an empty lang directory, then build_lang.pl will work (the /po directory is still there).

[hangy]

@hangy : if we leave an empty lang directory, then build_lang.pl will work (the /po directory is still there).

Good idea, but don't we need some kind of submodule, so that developers can test locally easily?

[stephanegigandet]

Good idea, but don't we need some kind of submodule, so that developers can test locally easily?

Maybe just a script that would do a git clone of openfoodfacts-web and link the /lang directory to the clone? Or maybe you have a better idea on how we could do it?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[stephanegigandet]

So we'll need to move those tests to openfoodfacts-web:

#   Failed test 'footer_legal_link link - lang: pt - textid: informacao-legal -- file /lang/pt/texts/informacao-legal.html does not exist'
#   at t/lang.t line 52.

#   Failed test 'footer_legal_link link - lang: fr - textid: mentions-legales -- file /lang/fr/texts/mentions-legales.html does not exist'
#   at t/lang.t line 52.

#   Failed test 'footer_terms_link link - lang: fr - textid: conditions-d-utilisation -- file /lang/fr/texts/conditions-d-utilisation.html does not exist'
#   at t/lang.t line 52.

#   Failed test 'footer_terms_link link - lang: pt - textid: termos-de-utilizacao -- file /lang/pt/texts/termos-de-utilizacao.html does not exist'
#   at t/lang.t line 52.
# Looks like you failed 4 tests of 376.
t/lang.t ......................... 

[stephanegigandet]

Done in PR #6113