Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /lang, add /lang-default. #6113

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Remove /lang, add /lang-default. #6113

merged 5 commits into from
Nov 26, 2021

Conversation

stephanegigandet
Copy link
Contributor

Replaces #5158
Fixes #6112

  • removed the /lang directory as it has been copied (and since then changed) in the openfoodfacts-web repository
  • created a /lang-default directory with 2 English texts needed to display the main page of product opener
  • some code changes to load /lang-default is /lang is not present

In production we will need to copy the /lang directory from openfoodfacts-web

In docker dev and preprod, we can also try to have a mechanism to download and copy /lang from openfoodfacts-web

@stephanegigandet stephanegigandet added the Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org label Nov 25, 2021
@stephanegigandet stephanegigandet requested a review from a team as a code owner November 25, 2021 11:12
@alexgarel
Copy link
Member

your turn to review @stephanegigandet

We should not merge until I made the deploy on https://github.com/openfoodfacts/openfoodfacts-web or preprod will fail.

Copy link
Contributor Author

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgarel your changes looks good to me

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel temporarily deployed to off-net November 26, 2021 17:36 Inactive
@alexgarel alexgarel merged commit 6a5e3e6 into main Nov 26, 2021
@alexgarel alexgarel deleted the remove-lang3 branch November 26, 2021 17:44
@stephanegigandet stephanegigandet mentioned this pull request Jan 4, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the /lang directory from openfoodfacts-server repository to openfoodfacts-web
2 participants