-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /lang, add /lang-default. #6113
Conversation
your turn to review @stephanegigandet We should not merge until I made the deploy on https://github.com/openfoodfacts/openfoodfacts-web or preprod will fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexgarel your changes looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
so that it can use the one from openfoodfacts-web
2b89573
to
937773a
Compare
Kudos, SonarCloud Quality Gate passed! |
Replaces #5158
Fixes #6112
In production we will need to copy the /lang directory from openfoodfacts-web
In docker dev and preprod, we can also try to have a mechanism to download and copy /lang from openfoodfacts-web