feat: add data quality warning for serving size without digit

[benbenben2]

Tested on Gitpod

Related to:

• Quality facet - Nutrition - serving_size="serving" for data-quality #5163
• Incorrect "serving" value for serving size field, Unilever import through the producers platform #5441
• Import of nutrition data specified for a serving size fail, and set the serving size to "serving" #6473

Questions (and answers):

1. should it involve nutrition_data_prepared as well?
   -> decision: yes
2. raise quality error tag - only when nutrition_data_per or nutrition_data_prepared_per are "on" (option 1) - vs - if string without digit value is in serving_size (even if nutrition_data_per or nutrition_data_prepared_per are missing) (option 2)
   -> decision: all (option 2) because as stated by @CharlesNepote "when users are often seeing this value they can think it's a good value" (Quality facet - Nutrition - serving_size="serving" for data-quality #5163)
3. how come serving_quantity=0 when it is "serving" or any string?
   -> in lib/ProductOpener/Food.pm, the subroutine normalize_serving_size extracts any digit and return it or 0 if nothing is found.
   3.1. can this be used to setup the error?
   -> it cannot be serving_quantity (using normalize_serving_size) because serving_quantity is undefined if the value is something like "serving 1 and serving 2 and serving 3", which contain digit
4. what name to give to the error?
   -> existing one is "en:serving-size-in-mg"
   -> plural was used for "EcoScore - threatened species - Ingredients missing"
   hence, "en:serving-size-is-missing-digits" seems to be a good choice

[codecov-commenter]

Codecov Report

Merging #8057 (b4631e9) into main (a67350e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8057      +/-   ##
==========================================
+ Coverage   44.70%   44.72%   +0.02%     
==========================================
  Files         100      100              
  Lines       20212    20220       +8     
  Branches     4636     4637       +1     
==========================================
+ Hits         9035     9043       +8     
  Misses      10103    10103              
  Partials     1074     1074              

Impacted Files	Coverage Δ
lib/ProductOpener/DataQualityFood.pm	56.65% <100.00%> (+0.24%)	⬆️
tests/unit/dataqualityfood.t	76.22% <100.00%> (+1.22%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[benbenben2]

Thank you @stephanegigandet
Your suggested code is working fine (tested with gitpod).
But for perltidy, no idea why it is failing (tried changing formatting, it is working with only 2 conditions but not with 3) :-(

[stephanegigandet]

But for perltidy, no idea why it is failing (tried changing formatting, it is working with only 2 conditions but not with 3) :-(

Hi @benbenben2, you need to run "make lint", and perltidy will change the indentation, split long lines etc.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[stephanegigandet]

Thank you!

[CharlesNepote]

Didn't have time to thank you, it's great!