Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More appealing empty history screen #1126

Closed
M123-dev opened this issue Feb 12, 2022 · 6 comments · Fixed by #1212
Closed

More appealing empty history screen #1126

M123-dev opened this issue Feb 12, 2022 · 6 comments · Fixed by #1212
Assignees
@bhattabhi013
Labels
good first issue Good for newcomers history 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… ⏲️ 5 minute fix

Comments

@M123-dev
Copy link
Member

What

  • Just this small centered text doesn't look friendly for someone who opened the app for the first time
  • From the mocks:

Screenshot 2022-02-12 125737
@teolemon teolemon added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… history and removed 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Feb 14, 2022
@bhattabhi013
Copy link
Contributor

I want to work on this but I'm confused about the text that should be displayed in place of the current text.

@monsieurtanuki
Copy link
Contributor

@bhattabhi013 Don't worry: just put a large icon, a bold title and a subtitle similar to what is displayed in the mock.
Then we may fine-tune.

@AshAman999
Copy link
Member

Can I work on this issue? :)

@monsieurtanuki
Copy link
Contributor

@bhattabhi013 Have you already started something?

@bhattabhi013
Copy link
Contributor

Hi @monsieurtanuki
Yes, I've started working on it and will be submitting PR for the same.

@bhattabhi013 bhattabhi013 mentioned this issue Mar 15, 2022
Merged
@M123-dev M123-dev linked a pull request Mar 15, 2022 that will close this issue
fix: #1126 More appealing empty history screen #1212
Merged
M123-dev pushed a commit that referenced this issue Mar 16, 2022
@bhattabhi013
fix: #1126 More appealing empty history screen (#1212)
91978c1 
* fixed #1126 More appealing empty history screen

* fix #1126

* fix #1126
@github-actions github-actions bot mentioned this issue Mar 16, 2022
Closed
M123-dev pushed a commit that referenced this issue Mar 17, 2022
@bhattabhi013
Fix#1214 (#1230)
d89999c 
* fixed #1126 More appealing empty history screen

* fix #1126

* fix #1126

* fixed 1214
M123-dev pushed a commit that referenced this issue Mar 19, 2022
@bhattabhi013
fix: #824 - Harmonize top margin in settings (#1262)
07fef4e 
* fixed #1126 More appealing empty history screen

* fix #1126

* fix #1126

* fixed 1214

* fix#824

* resolved conflicts

* Harmonize top margin in settings
M123-dev pushed a commit that referenced this issue Mar 20, 2022
@bhattabhi013
fix #1174 - Add SmoothAnimatedColapseArrow (local widget) to the sect…
93010ab 
…ions in the settings (#1259)

* fixed #1126 More appealing empty history screen

* fix #1126

* fix #1126

* fixed 1214

* fix #1174

* removed comments and fix#1174

* removed import

* fix #1174 - Add SmoothAnimatedColapseArrow (local widget) to the sections in the settings
@monsieurtanuki
Copy link
Contributor

Just a remark: it's very tempting, when on the empty history page, to click on the big central icon to start scanning. But nothing happens.

@M123-dev M123-dev mentioned this issue Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhattabhi013 bhattabhi013

Labels
good first issue Good for newcomers history 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… ⏲️ 5 minute fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #1126 More appealing empty history screen
5 participants
@teolemon @monsieurtanuki @M123-dev @bhattabhi013 @AshAman999