Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub specials #113

Merged
merged 14 commits into from
Jan 22, 2021
Merged

GitHub specials #113

merged 14 commits into from
Jan 22, 2021

Conversation

M123-dev
Copy link
Member

Added:
FUNDING.yml
ci.yml

FUNDING just provides links to support OFF in the github repo and ci.yml is a workflow which tests whether new pull requests work

teolemon
teolemon reviewed Jan 21, 2021
View reviewed changes
.github/FUNDING.yml Outdated Show resolved Hide resolved
teolemon
teolemon reviewed Jan 21, 2021
View reviewed changes
.github/workflows/ci.yml
pull_request:
branches: [ master ]

# on: push # Default will running for every branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not for PRs as well ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running tests on branches, for pull requests ? To check they don't break anything before merging ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

monsieurtanuki
monsieurtanuki reviewed Jan 22, 2021
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @M123-dev, I cannot be helpful here, I don't have any knowledge on this stuff (to the point that I call that 'this stuff').
The only thing I can say is that I have a vague concern about the upgraded version of gradle (gradle-6.8-all.zip): does it impact the minSdkVersion?

@M123-dev
Copy link
Member Author

@monsieurtanuki Gradle version 6 doesn't change the minSdkVersion, I just had to update it, otherwise the build would not have worked.
When testing with -v I got a hint, namely that many native functions of the qr_code_scanner will no longer be supported from the next major version of gradle.
But it will be a long time before we have to update.

@M123-dev M123-dev merged commit 95b479d into openfoodfacts:master Jan 22, 2021
@M123-dev M123-dev deleted the github-specials branch January 22, 2021 16:17
@M123-dev M123-dev mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon left review comments

@monsieurtanuki monsieurtanuki monsieurtanuki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M123-dev @teolemon @monsieurtanuki