-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 4223 - comparison page for 3 random products on dev mode #4444
Conversation
New file: * `compare_products3_page.dart`: Test page about comparing 3 products. Work in progress. Impacted files: * `attributes_card_helper.dart`: refactored introducing two new reusable methods * `nutrition_container.dart`: refactored introducing one reusable getter * `product_cards_helper.dart`: refactored introducing one new reusable method * `user_preferences_dev_mode.dart`: added an item computing 3 random products and showing the product comparison page
Codecov Report
@@ Coverage Diff @@
## develop #4444 +/- ##
===========================================
- Coverage 10.31% 10.21% -0.10%
===========================================
Files 296 297 +1
Lines 15431 15578 +147
===========================================
Hits 1591 1591
- Misses 13840 13987 +147
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
You can test this PR on: Android |
error • Target of URI doesn't exist: 'package:smooth_app/data_models/user_preferences.dart' • packages/smooth_app/lib/pages/preferences/user_preferences_dev_mode.dart:13:8 • uri_does_not_exist |
Dammit, now I'm out of sync with the |
Thanks a lot @monsieurtanuki for this POC and we would like to ship to full feature in the next release. However, what would be interesting here, is to have the ability to create this comparison, by selecting products. |
I think I would have to impact the multi-select mode then. Not adding the (un)select all feature, but giving more possible actions (in this case, one additional "boosted compare" action). |
Impacted files: * `product_list_page.dart`: slightly refactored the app bar text in selection mode, in order to have several possible actions; replaced the FAB with an explicit (?) "multi-select" button; added a "boosted comparison" icon button when 2 or 3 products are selected; added a "ranking" icon button * `user_preferences_dev_mode.dart`: added a dev mode flag for "boosted comparison" (sic)
@g123k Latest changes - access to boosted comparison from list page via dev mode Impacted files:
Screenshots:
Obviously the choice of a half-star is not relevant for the boosted comparison. The "normal comparison" being more a ranking, the boosted comparison could use the "comparison arrows" and the "normal comparison" could use the sport cup instead. |
@g123k You may be right but that was the purpose of the issue.
That would mean horizontal and vertical scrolling, which is a bit acrobatic, UX-wise.
Indeed we are. |
|
Yes, that would be great |
New file: * `product_list_item_popup_items.dart`: Popup menu items for the product list page, for selected items. Impacted files: * `product_list_page.dart`: now displays item actions in a "more..." menu * `product_list_popup_items.dart`: minor refactoring
@teolemon More like this (latest push)?
|
Let's merge and refine |
What
Screenshot
Part of
Files
New file:
compare_products3_page.dart
: Test page about comparing 3 products. Work in progress.Impacted files:
attributes_card_helper.dart
: refactored introducing two new reusable methodsnutrition_container.dart
: refactored introducing one reusable getterproduct_cards_helper.dart
: refactored introducing one new reusable methoduser_preferences_dev_mode.dart
: added an item computing 3 random products and showing the product comparison page