Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5102 - fixed the path of the database to backup #5103

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

domain Specifies the location of resource. Valid values for this attribute include the following:

  • database: directories returned by getDatabasePath(). Databases created with SQLiteOpenHelper are stored here.

For the record (1) the database folder created by our app is databases/ (as returned getDatabasesPath()).
Does that mean that we should put databases/smoothie.db, or just smoothie.db? Let's try, it's either with or without explicitly mentioning databases/.

For the record (2) the amount of backed-up data is limited to 25 Mb. Which means that we would probably be better off NOT including the sqflite database (which is meant to grow far beyond 25 Mb), so that the rest of the data can be backed up. Then comes the question: how to make sense of lists of barcodes if we don't have locally the matching products?

Fixes bug(s)

@monsieurtanuki
Copy link
Contributor Author

cc @linsui

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.53%. Comparing base (4d9c7fc) to head (520e34d).
Report is 53 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5103      +/-   ##
==========================================
- Coverage     9.54%   9.53%   -0.02%     
==========================================
  Files          325     327       +2     
  Lines        16411   16529     +118     
==========================================
+ Hits          1567    1576       +9     
- Misses       14844   14953     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linsui
Copy link

linsui commented Mar 3, 2024

@monsieurtanuki
Copy link
Contributor Author

https://gitlab.com/linsui/fdroiddata/-/jobs/6305195522 It works, thanks!

@linsui Cool!
cc @teolemon @g123k for PR approval if relevant.

@teolemon teolemon added Database backup 🐛 bug Something isn't working labels Apr 8, 2024
@monsieurtanuki monsieurtanuki merged commit cd563f5 into openfoodfacts:develop Apr 8, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon @linsui for your review and tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Database backup
Development

Successfully merging this pull request may close these issues.

F-Droid build failed
4 participants